Skip to content

Commit

Permalink
Skip back five tests that passed locally
Browse files Browse the repository at this point in the history
  • Loading branch information
tbennun committed Nov 10, 2024
1 parent 08cbfa4 commit 5993b69
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 1 deletion.
2 changes: 2 additions & 0 deletions tests/fpga/jacobi_fpga_test.py
Original file line number Diff line number Diff line change
@@ -1,10 +1,12 @@
# Copyright 2019-2021 ETH Zurich and the DaCe authors. All rights reserved.
from dace.fpga_testing import xilinx_test, import_sample
from pathlib import Path
import pytest


# This kernel does not work with the Intel FPGA codegen, because it uses the
# constant systolic array index in the connector on the nested SDFG.
@pytest.mark.skip('Xilinx failure due to unresolved phi nodes, Intel FPGA failure due to systolic array index')
@xilinx_test(assert_ii_1=False)
def test_jacobi_fpga():
jacobi = import_sample(Path("fpga") / "jacobi_fpga_systolic.py")
Expand Down
1 change: 1 addition & 0 deletions tests/fpga/map_unroll_processing_elements_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
from dace.config import set_temporary


@pytest.mark.skip('Xilinx HLS fails due to unresolved phi nodes')
@xilinx_test(assert_ii_1=False)
def test_map_unroll_processing_elements():
# Grab the systolic GEMM implementation the samples directory
Expand Down
2 changes: 2 additions & 0 deletions tests/fpga/matmul_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -162,6 +162,7 @@ def test_gemm_vectorized():
return sdfg


@pytest.mark.skip('Xilinx HLS fails due to unresolved phi nodes')
@xilinx_test(assert_ii_1=True)
def test_gemm_vectorized_decoupled():
# Test with vectorization
Expand Down Expand Up @@ -200,6 +201,7 @@ def test_gemm_size_not_multiples_of():
return sdfg


@pytest.mark.skip('Xilinx HLS fails due to unresolved phi nodes')
@xilinx_test()
def test_gemm_size_not_multiples_of_decoupled():
# Test with matrix sizes that are not a multiple of #PEs and Tile sizes
Expand Down
3 changes: 2 additions & 1 deletion tests/python_frontend/conditional_assignment_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@ def some_func(field, may_be_none):
assert np.allclose(field, 1.0)


@pytest.mark.skip('Reference scalars unsupported in Python frontend (fails without simplification)')
def test_maybe_none_scalar_arg():
@dace.program
def some_func(field, a_scalar):
Expand Down Expand Up @@ -133,7 +134,7 @@ def func():
# test_none_or_field_assignment_globalarr()
# test_none_or_field_assignment_arr()
test_none_arg()
test_maybe_none_scalar_arg()
# test_maybe_none_scalar_arg()
test_default_arg()
test_kwarg_none()
test_conditional_print()

0 comments on commit 5993b69

Please sign in to comment.