Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom icon for SDFG files (workaround) #1

Merged
merged 3 commits into from
May 26, 2020
Merged

Custom icon for SDFG files (workaround) #1

merged 3 commits into from
May 26, 2020

Conversation

tbennun
Copy link
Contributor

@tbennun tbennun commented May 22, 2020

Waiting for microsoft/vscode#14662 to be closed.

@tbennun tbennun changed the title Custom icon for SDFG files (on hold) Custom icon for SDFG files (workaround) May 23, 2020
@tbennun tbennun requested a review from phschaad May 23, 2020 16:09
@tbennun
Copy link
Contributor Author

tbennun commented May 23, 2020

@phschaad I worked around the problem by copying the master Seti icon set and adding SDFGs. This is a temporary fix and I set up Issue #2 for tracking it.

phschaad
phschaad approved these changes May 26, 2020
View reviewed changes
Copy link
Collaborator

@phschaad phschaad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@phschaad phschaad merged commit e6a1b1a into master May 26, 2020
@phschaad phschaad deleted the custom-icon branch May 26, 2020 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phschaad phschaad phschaad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tbennun @phschaad