Allow running in vanilla PHP projects #25
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
symfony/process
is a hard requirement for the project but is no included in the dependency list.shiki-php/src/Shiki.php
Lines 64 to 72 in 1895983
shiki-php/src/Shiki.php
Lines 82 to 84 in 1895983
This means the package is not usable outside of projects that already depend on
symfony/process
. I hit this on a recent project and had to manually installsymfony/process
even though I was not interacting with it directly.I tested 5.0, 6.0, and 7.0 against the testsuite and static analysis and all the tests passed on my machine and not additional static analysis issues were introduced with either version.