Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does downgrade so Shiki does support PHP7.4 on top of PHP8 support.
To make the tests pass, I needed to remove some nice PHP8 syntax.
The good thing is, that someone who is using Shiki with PHP 8, can still use the nice PHP 8 syntax. It does only affect those, who wanna use it with PHP7.4.
Motivation
It's a little dependency fun :-)
We are working on a PR to add TipTap 2 for Statamic. Statamic does support PHP 7.4 at the moment.
statamic/cms#6043
To upgrade, Statamic requires tiptap-php
In theory, it does support PHP 7.4
As tiptap does require shiki, shiki does require PHP 8 which does prevent it from beeing usable with PHP 7.4