requested minor adjustments from round 2 reviews

spatie · Jun 10, 2024 · ddb0443 · ddb0443
1 parent 99f18ad
commit ddb0443
Show file tree

Hide file tree

Showing 6 changed files with 14 additions and 10 deletions.
diff --git a/src/Exceptions/InvalidLayerMethod.php b/src/Exceptions/InvalidLayerMethod.php
@@ -6,7 +6,7 @@
 
 class InvalidLayerMethod extends Exception
 {
-    public static function for(int $value)
+    public static function for(int $value): static
     {
         return new static("Invalid layer method value ({$value}).");
     }

diff --git a/src/Exceptions/InvalidQuality.php b/src/Exceptions/InvalidQuality.php
@@ -2,9 +2,11 @@
 
 namespace Spatie\PdfToImage\Exceptions;
 
-class InvalidQuality extends \Exception
+use Exception;
+
+class InvalidQuality extends Exception
 {
-    public static function for(int $value): self
+    public static function for(int $value): static
     {
         return new static("Quality must be between 1 and 100, {$value} given.");
     }

diff --git a/src/Exceptions/InvalidSize.php b/src/Exceptions/InvalidSize.php
@@ -2,19 +2,21 @@
 
 namespace Spatie\PdfToImage\Exceptions;
 
-class InvalidSize extends \Exception
+use Exception;
+
+class InvalidSize extends Exception
 {
-    public static function for(int $value, string $type, string $property): self
+    public static function for(int $value, string $type, string $property): static
     {
         return new static(ucfirst($type)." {$property} must be greater than or equal to 0, {$value} given.");
     }
 
-    public static function forThumbnail(int $value, string $property): self
+    public static function forThumbnail(int $value, string $property): static
     {
         return self::for($value, 'thumbnail', $property);
     }
 
-    public static function forImage(int $value, string $property): self
+    public static function forImage(int $value, string $property): static
     {
         return self::for($value, 'image', $property);
     }

diff --git a/src/Exceptions/PageDoesNotExist.php b/src/Exceptions/PageDoesNotExist.php
@@ -6,7 +6,7 @@
 
 class PageDoesNotExist extends Exception
 {
-    public static function for(int $pageNumber): self
+    public static function for(int $pageNumber): static
     {
         return new static("Page {$pageNumber} does not exist.");
     }

diff --git a/src/Exceptions/PdfDoesNotExist.php b/src/Exceptions/PdfDoesNotExist.php
@@ -6,7 +6,7 @@
 
 class PdfDoesNotExist extends Exception
 {
-    public static function for(string $pdfFile): self
+    public static function for(string $pdfFile): static
     {
         return new static("File '{$pdfFile}' does not exist.");
     }

diff --git a/src/Pdf.php b/src/Pdf.php
@@ -303,7 +303,7 @@ protected function determineOutputFormat(string $pathToImage): OutputFormat
         return $outputFormat;
     }
 
-    protected function validatePageNumbers(int ...$pageNumbers)
+    protected function validatePageNumbers(int ...$pageNumbers): void
     {
         $count = $this->pageCount();