-
-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Laravel 11.x Compatibility #98
Conversation
|
|
⚗️ Using this package? If you would like to help test these changes or believe them to be compatible, you may update your project to reference this branch. To do so, temporarily add Shift's fork to the {
"repositories": [
{
"type": "vcs",
"url": "https://github.com/laravel-shift/laravel-server-side-rendering.git"
}
]
} Then update your dependency constraint to reference this branch: {
"require": {
"spatie/laravel-server-side-rendering": "dev-l11-compatibility",
}
} Finally, run: |
@laravel-shift The L11 tests are failing here, could you take a look? |
@freekmurze, my guess is the upstream dependency is not yet compatible. |
Any chance this can get merged? We need to upgrade L11 and I see this PR is 3 weeks old. Thanks! |
Looks like tagging "spatie/laravel-server-side-rendering": "dev-l11-compatibility@dev",
"spatie/server-side-rendering": "dev-main@dev as 0.3.3", "repositories": [
{
"type": "vcs",
"url": "https://github.com/laravel-shift/laravel-server-side-rendering"
}
], Once I get the rest of the L11 Shift squared away, we'll see whether this passes CI, as we should be able to confirm SSR as part of our test suite. I should have an answer later tonight, given that I've started down this rabbit hole. |
Yep, things do seem to work for us if you use the newer version of the underlying dep (the one that supports Symfony Process 7.x). |
Could you make sure that all tests pass? Feel free to drop support for older Laravel / PHP / package versions. |
To confirm, should I get that prior to the underlying package being tagged, or wait for you to tag 0.3.3? Thinking that once 0.3.3 is tagged on the base SSR package, rerunning tests here will turn everything green, but if it's useful to pin the dep to dev-main as a proof of concept, I'll fork off of this branch with that tweak and do so. |
Let's see if this works... https://github.com/iansltx/laravel-server-side-rendering/actions/runs/8403029210 |
Dear contributor, because this pull request seems to be inactive for quite some time now, I've automatically closed it. If you feel this pull request deserves some attention from my human colleagues feel free to reopen it. |
This is an automated pull request from Shift to update your package code and dependencies to be compatible with Laravel 11.x.
Before merging, you need to:
l11-compatibility
branchIf you do find an issue, please report it by commenting on this PR to help improve future automation.