Support json string on cast setter #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freekmurze
requested changes
Oct 28, 2021
erikn69
force-pushed
the
cast_support_json_string
branch
3 times, most recently
from
798097a to
4a2673c
Compare
freekmurze
requested changes
Oct 29, 2021
|
Also make sure that the tests pass. |
erikn69
force-pushed
the
cast_support_json_string
branch
2 times, most recently
from
10abc82 to
a945bd7
Compare
|
@freekmurze fixed and all tests passed PHPUnit 9.5.10 by Sebastian Bergmann and contributors.
Runtime: PHP 8.0.5
Configuration: /attributes/phpunit.xml.dist
...................................... 38 / 38 (100%)
Time: 00:03.246, Memory: 20.00 MB
OK ( 38 tests, 65 assertions)Here test fail by commit c1ef72f?diff=split, you deleted |
freekmurze
requested changes
Oct 29, 2021
erikn69
force-pushed
the
cast_support_json_string
branch
2 times, most recently
from
136636a to
1aab70c
Compare
erikn69
force-pushed
the
cast_support_json_string
branch
from
1aab70c to
8cf7d8e
Compare
|
X2 |
fredsal
approved these changes
Nov 5, 2021
erikn69
force-pushed
the
cast_support_json_string
branch
from
8bde0ab to
c01e504
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It can be useful when using js plugins that send post as json string automatically