Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't write to horizon config when not available #116

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

Propaganistas
Copy link
Contributor

When having both schedule-monitor and failed-job-monitor installed without Horizon, failed-job-monitor will still regard Horizon as being installed because schedule-monitor writes to horizon config by default. Let's avoid that.

See:
https://github.com/spatie/laravel-failed-job-monitor/blob/1b4c4d3f051a1033ce6ead5433bea850bbf20878/src/Notification.php#L41

@freekmurze freekmurze merged commit 0b3b6d5 into spatie:main Dec 16, 2024
6 of 12 checks passed
@freekmurze
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants