Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for visibility #92

Merged
merged 1 commit into from
Mar 1, 2024
Merged

Add support for visibility #92

merged 1 commit into from
Mar 1, 2024

Conversation

msucevan
Copy link
Contributor

This commit is aimed to support the visibility, in order to set to public when necessary specially when you need to use s3 as disk.

@msucevan
Add support for visibility
8bda156 
This commit is aimed to support the visibility, in order to set to public when necessary specially when you need to use s3 as disk.
@freekmurze freekmurze merged commit 69957c4 into spatie:main Mar 1, 2024
1 check passed
@freekmurze
Copy link
Member

Thanks!

@binotaliu
Copy link

binotaliu commented Jun 24, 2024 •
edited
Loading

This is probably a BC-break change, as private is not the default visibility for all disks. E.g. the default visibility for public disk is public (755 for dir and 644 for files.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@msucevan @freekmurze @binotaliu