feat(http-client/injecting): adding 'withTrace' macro for Http Client #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… injection of current span context id
|
Probably WIP, 'cause I dislike impl of toTraceContextID function in Span class in flags. Probably it should be inherited from Measure. But it must be implemented in other feature gates, such as |
|
Ping me when this one is ready for review. |
|
@freekmurze probably, it is |
freekmurze
requested changes
Jan 4, 2023
config/open-telemetry.php
Outdated
| @@ -94,4 +94,16 @@ | |||
| * This class generates ids for both traces and spans. | |||
| */ | |||
| 'id_generator' => Spatie\OpenTelemetry\Support\IdGenerator::class, | |||
|
|
|||
| /* | |||
| * Injectors configure, how span will be injected into other structures | |||
There was a problem hiding this comment.
Let's first try to have the simplest implementation possible, without this config. Could you adjust this PR so that it just adds the macro and the tests to make sure that it works?
There was a problem hiding this comment.
@freekmurze done in 1110cf7
|
Thanks, I'll simplify it even further on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.