Add @return $this annotation to methods #3780
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3777 and #3779 added generics to
InteractsWithMedia
andFileAdder
, which improves PHPStan recognition of return types. However, PHPStan is still unable to follow through chaining; for instance, it will interpret the return value of:as the base
Media
class, even if an extended class has been specified.This PR fixes that by listing the return type of a bunch of methods as
$this
. These include methods in theFileAdder
class, needed for the example above; but I have also included several others (mostly with generics, where I believe it's most useful, but not only).