L7 route caching issue #4
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not 100% sure, but I think this is a breaking change. Removing that character will make Laravel append the default namespace (for people that are using that). |
|
@patrickbrouwers is this still an issue? I remember submitting a PR to laravel/framework for something related to this laravel/framework#32512 |
|
@riasvdv I don't think it is anymore. |
|
Ok, closing this for now then! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove \ from webhook controller definition to solve issues with L7 route caching. I'm not sure if the
\\is there for a reason, but removing it solves the issues with route caching. Same applies to the other feedback packages.Laravel compares the controller names here:
vendor/laravel/framework/src/Illuminate/Routing/CompiledRouteCollection.php:215But as the action doesn't have a\and the controller does, the comparison fails.