Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update command name to match class name #490

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

ph7jack
Copy link
Contributor

@ph7jack ph7jack commented Oct 11, 2024

Description

This PR aims to fix a problem in the EventSourcingServiceProvider:54, where the clear command is typed differently from the command signature.

Screenshot 2024-10-10 at 22 43 39

Fixed Error when running optimize:clear

Screenshot 2024-10-10 at 22 44 15

Copy link
Member

@sebastiandedeyne sebastiandedeyne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm I this fix should be the other way around: EventSourcingServiceProvider:54 should be updated, not the command signature. Otherwise it's a breaking change.

@ph7jack
Copy link
Contributor Author

ph7jack commented Oct 14, 2024

@sebastiandedeyne Sure, it makes sense. I've made the change.

@sebastiandedeyne sebastiandedeyne merged commit eebf9d1 into spatie:main Oct 14, 2024
@sebastiandedeyne
Copy link
Member

Thanks!

@ph7jack ph7jack deleted the patch-1 branch October 14, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants