Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SerializableClosure security provider #53

Closed
wants to merge 1 commit into from
Closed

Remove SerializableClosure security provider #53

wants to merge 1 commit into from

Conversation

shrimpwagon
Copy link

If a secret key was set on the SerializableClosure then any future closure will be signed. This occurs in the Laravel framework. The child processes are not ran in Laravel thus not using the secret key that was set thus failing. This edit will temporarily remove the security provider, create an unsigned closure and set the provider back to original.

If a secret key was set on the SerializableClosure then any future closure will be signed. This occurs in the Laravel framework. The child processes are not ran in Laravel thus not using the secret key that was set thus failing. This edit will temporarily remove the security provider, create an unsigned closure and set the provider back to original.
@msarca
Copy link

msarca commented Dec 3, 2018

This PR won't fix the issue. The signing occurs at serialization time, not when the SerializableClosure class is instantiated. Moreover, if the value returned by the getSecurityProvider method is null, an exception will be thrown when passing null as an argument to the addSecurityProvider method. The correct solution was already posted.

@brendt
Copy link
Contributor

brendt commented Dec 3, 2018

So I guess I'll close this one, as this seems to be the solution: #52 (comment)

@brendt brendt closed this Dec 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants