This repository has been archived by the owner on Aug 29, 2024. It is now read-only.
Wrap with null check to avoid crash bug on quit for deployments #666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
improbable-prow-robot
added
the
size/XS
|
Quick note, this crash happens if you quit via the UI, or |
|
Ah man. It would be much easier if these events were on the SpatialWorkerConnection rather than the NetDriver because the lifetimes are totally different. With the null check we avoid the crash but effectively lose the OnDisconnect callback on game exit |
improbable-valy
approved these changes
Feb 13, 2019
|
@padhansell in this case, disconnection from Spatial happens as a result of quitting the game. My understanding was that the callbacks were meant to trigger some game logic when the disconnection is triggered by Spatial while the client is still alive. |
m-samiec
approved these changes
Feb 13, 2019
DW-Sebastien
pushed a commit
to Darewise/UnrealGDK
that referenced
this pull request
Feb 13, 2019
Vatyx
pushed a commit
that referenced
this pull request
Feb 26, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There was a crash bug due to having a null netdriver when attempting to quit from a built out client. Adding a null check before the call stops this crash arising.
Tests
Tested on shooter game, in editor, and in playtest (13/02/19 - will wait until QA confirm it doesn't occur when using this fix before merging it.)
Primary reviewers
@m-samiec @joshuahuburn