Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mobile Header Component #8

Merged
merged 4 commits into from
Apr 11, 2019
Merged

Mobile Header Component #8

merged 4 commits into from
Apr 11, 2019

Conversation

savannahostrowski
Copy link
Contributor

This PR creates a mobile header component with swipeable drawers (to be populated).

@savannahostrowski savannahostrowski changed the title Header Component Mobile Header Component Apr 8, 2019
@savannahostrowski savannahostrowski mentioned this pull request Apr 9, 2019
Merged
nachtm
nachtm approved these changes Apr 11, 2019
View reviewed changes
Copy link
Contributor

@nachtm nachtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great -- swiping works really well. Nice job!

The filter button looks a little lonely without the search bar, so it might be worth revisiting the design later to account for that. I'm not really sure what the best solution is.

@savannahostrowski
Copy link
Contributor Author

@nachtm I agree - I think we can refine the UI here later when we do a design review!

sayas01
sayas01 approved these changes Apr 11, 2019
View reviewed changes
Copy link
Contributor

@sayas01 sayas01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes!

@savannahostrowski savannahostrowski merged commit dda773f into master Apr 11, 2019
@savannahostrowski savannahostrowski deleted the header branch April 11, 2019 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nachtm nachtm nachtm approved these changes

@sayas01 sayas01 sayas01 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@savannahostrowski @nachtm @sayas01