Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load user-provided PortAudio name/path from environ's SD_PORTAUDIO #499

Closed
wants to merge 2 commits into from

Conversation

arkrow
Copy link
Contributor

@arkrow arkrow commented Oct 30, 2023

Implements the necessary functionality suggested in one of the discussions in #130.

Loads a user-specified PortAudio binary during runtime, by either providing its filename as usual or providing its absolute path. Providing a PortAudio binary's filename (if the directory it resides in exists in PATH), as well as its absolute path works on Windows, though needs confirmation on other platforms.

@pep8speaks
Copy link

pep8speaks commented Oct 30, 2023

Hello @arkrow! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 63:80: E501 line too long (81 > 79 characters)
Line 73:80: E501 line too long (85 > 79 characters)

Comment last updated at 2024-01-21 18:15:02 UTC

@mgeier
Copy link
Member

mgeier commented Jan 21, 2024

I have documented how to load a custom PortAudio library: #518

@arkrow Do you think your PR is still needed, since users can already use custom DLLs etc.?

@arkrow
Copy link
Contributor Author

arkrow commented May 28, 2024

I have documented how to load a custom PortAudio library: #518

@arkrow Do you think your PR is still needed, since users can already use custom DLLs etc.?

One advantage this implementation has is that it solves potential PATH shadowing issues (e.g. another directory with portaudio is in PATH and has higher precedence/order, so it is loaded instead of the custom portaudio binary that a developer shipped with their package/software and intended to use).

I think it'd be good to continue the discussion in #130. I can pick up this PR again in the future if you are open to this implementation and other members of the community find it useful for their use case.

@mgeier
Copy link
Member

mgeier commented Oct 5, 2024

In the meantime, it is ...

Do we still need this PR?

@arkrow
Copy link
Contributor Author

arkrow commented Oct 15, 2024

Hey @mgeier,

Thanks for following up with the documentation on the other PR! I was occupied lately and unfortunately couldn't continue till now.

This PR is no longer necessary, since there is no current use case or demand for loading custom PortAudio binaries dynamically just before import time. The windows ASIO use case is covered on the other PR.

I'll be closing the PR for now. Since the logic implemented here is quite simple, it can be picked up again if needed by other contributors.

@arkrow arkrow closed this Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants