Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sparrow Server Dockerfile #728

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

sethforprivacy
Copy link

This Dockerfile downloads, verifies, and allows the usage of Sparrow Server via Docker.

@craigraw
Copy link
Collaborator

craigraw commented Nov 2, 2022

Thanks for this @sethforprivacy. Do you think it's worthwhile having this here as well as in https://github.com/sethforprivacy/sparrow-server-docker? I'm always mindful of keeping the scope of maintenance on the project to a manageable level.

@sethforprivacy
Copy link
Author

I prefer to have it upstream as well as an example and in case you want to have docs for building Sparrow via Docker, but it's really your final decision.

I'll work to keep my image up to date, so if you don't want it in the repo, feel free to reject the PR!

@benpbolton
Copy link

I could see a link to https://github.com/sethforprivacy/sparrow-server-docker in the README or docs for those interested in a verified Docker implementation, but agree that keeping scope focused is probably the bigger win.

@suurt8ll
Copy link

@sethforprivacy seems to have archived his repository. Just giving heads up for future readers.

@sethforprivacy
Copy link
Author

@sethforprivacy seems to have archived his repository. Just giving heads up for future readers.

Note that the Dockerfile is still useful, but I don't see any point in maintaining it as the only reason I know of for people to use sparrow-server was to be able to remix easily. If there is a clear need I'm happy to revive it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants