This repository has been archived by the owner on Dec 4, 2019. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've received a security notice for lnd-engine that asks us to upgrade grpc to a version > 1.12.x. This PR updates grpc to latest to relieve this notice.
Vulnerability: our current version of node-grpc depends on protobufjs < 5.0.3 which has a DoS security issue. The security issue is a RegEx DoS attack where the evaluation of a certain string takes a long amount of time (and can effectively jam the process using protobufjs)
More info on ReDos: https://www.owasp.org/index.php/Regular_expression_Denial_of_Service_-_ReDoS
Fix in protobufjs protobufjs/protobuf.js#1030
https://www.npmjs.com/advisories/605