refactor: 💡 unwrap api response result for easier access

BREAKING CHANGE: 🧨 disbursements isPayerActive now returns simple boolean
sparkplug · Mar 31, 2021 · 29bd1d1 · 29bd1d1
1 parent 3b74e6e
commit 29bd1d1
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/examples/disbursements.js b/examples/disbursements.js
@@ -14,9 +14,9 @@ const partyIdType = momo.PayerType.MSISDN;
 // Transfer
 disbursements
     .isPayerActive(partyId, partyIdType)
-    .then((data) => {
-        console.log(data);
-        if (!data || !data.result || data.result !== true) {
+    .then((isActive) => {
+        console.log("Is Active ? ", isActive);
+        if (!isActive) {
             return Promise.reject("Party not active");
         }
         return disbursements.transfer({

diff --git a/src/disbursements.ts b/src/disbursements.ts
@@ -175,9 +175,10 @@ export default class Disbursements {
   public isPayerActive(
     id: string,
     type: PartyIdType = PartyIdType.MSISDN
-  ): Promise<{ result: boolean }> {
+  ): Promise<boolean> {
     return this.client
       .get<{ result: boolean }>(`/disbursement/v1_0/accountholder/${String(type).toLowerCase()}/${id}/active`)
-      .then(response => response.data);
+      .then(response => response.data)
+      .then(data => data.result ? data.result : false)
   }
 }