Add convenience wrapper for pragma optimize #572
Conversation
alexcwatt
force-pushed
the
pragma-optimize
branch
from
452e706
to
29840dd
Compare
|
@alexcwatt Thanks for this! The omission was mentioned by @rickhull in #559 If we're going to allow the optimize bits to be passed in by the caller, I'd like the API to be a bit more developer-friendly. Would you consider defining some constants in Our test coverage is pretty bad right now for the pragma methods, so as long as we keep the implementation simple, I think it's probably OK to not have test coverage (or to use a mock to test that the method calls what it should). |
| @@ -338,6 +338,14 @@ def mmap_size=(size) | |||
| set_int_pragma "mmap_size", size | |||
| end | |||
|
|
|||
| def optimize(bitmask = nil) | |||
| if bitmask | |||
There was a problem hiding this comment.
I'd like to see these bits made available as constants like many of the other sqlite bitmasks in lib/sqlite3/constants.rb
There was a problem hiding this comment.
That's a good idea. I took a pass at this; please let me know what you think.
flavorjones
force-pushed
the
pragma-optimize
branch
from
cf678c9
to
958f700
Compare
|
And I rebased off |
flavorjones
force-pushed
the
pragma-optimize
branch
from
4d4b512
to
d975892
Compare
The SQLite docs recommend some cases where
PRAGMA optimize;should be used: https://www.sqlite.org/pragma.html#pragma_optimizeI have discovered recently a case where this helped a project at work (https://twitter.com/alexcwatt/status/1851094243323912631) and now I'm wondering about how to make this easier to discover and use.
Do we want a way to test that these wrappers translate to the expected
executecall? I wasn't sure what tests to write for this change.