Fix to build for x64-mswin64 #629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tenderlove
added a commit
that referenced
this pull request
Mar 5, 2012
Fix to build for x64-mswin64
|
Is the intention here to build a mswin64 release for 1.5.1? If so, I'm going to need a 64-bit windows install. |
|
@flavorjones I think my machine is mswin64. I might be able to do that build. |
|
I should be able to build it, obviously. I just mean that I have no ability to verify that the gem actually installs and works. |
|
@flavorjones hah. If you build it, I will test it. I'm very sure my win7 machine is 64bit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fixed to build Nokogiri for Ruby x64-mswin64.
I tested on ruby 1.9.3p125 (2012-02-16) [x64-mswin64_100].