ci: drop valgrind on 2.7 #2892
Merged
ci: drop valgrind on 2.7 #2892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
because there seems to be a compaction bug in 2.7 that occasionally (rarely) gets triggered. it happens more frequently on windows, where we get segfaults, but sometimes valgrind catches it on linux, too. e.g. https://github.com/sparklemotion/nokogiri/actions/runs/5063811163/jobs/9090845467?pr=2890#step:7:3154 ``` == Invalid read of size 4 ==780== at 0x4908CB0: rb_gc_location (gc.c:8136) ==780== by 0x4908CB0: rb_gc_location (gc.c:8127) ==780== by 0x4A4CAD1: transient_heap_block_update_refs (transient_heap.c:831) ==780== by 0x4A4CAD1: transient_heap_blocks_update_refs (transient_heap.c:847) ==780== by 0x4A4CAD1: rb_transient_heap_update_references (transient_heap.c:859) ==780== by 0x490FCA1: gc_update_references (gc.c:8433) ==780== by 0x490FCA1: gc_compact_after_gc (gc.c:8576) ==780== by 0x4911052: gc_compact (gc.c:8477) ==780== by 0x4911052: gc_verify_compaction_references (gc.c:8683) ```
flavorjones
added
topic/ci
topic/memory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem is this PR intended to solve?
ci: drop valgrind checks on Ruby 2.7
because there seems to be a compaction bug in 2.7 that occasionally (rarely) gets triggered. it happens more frequently on windows, where we get segfaults, but sometimes valgrind catches it on linux, too.
e.g. https://github.com/sparklemotion/nokogiri/actions/runs/5063811163/jobs/9090845467?pr=2890#step:7:3154
This PR also updates the version of Ruby used for some jobs to 3.2 (those jobs that don't need a specific version of Ruby).