Improve gumbo error messages during tree construction #2863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevecheckoway
approved these changes
Apr 27, 2023
adding punctuation, cleaning up whitespace, and naming the input tag If the message was: > 1:13: ERROR: This tag isn't allowed here Currently open tags: html, body, div, table. it is now something like: > 1:13: ERROR: Start tag 'svg' isn't allowed here. Currently open tags: html, body, div, table.
flavorjones
force-pushed
the
flavorjones-improve-gumbo-error-messages
branch
from
feea968 to
37c29a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem is this PR intended to solve?
Gumbo tree constructions errors could be improved. In this PR we're adding punctuation, cleaning up whitespace, and naming the input tag.
If the message was:
it is now:
Have you included adequate test coverage?
No tests exist for error message contents. This is a potential area we could improve in the future.
Does this change affect the behavior of either the C or the Java implementations?
No behavioral changes other than the contents of the error message.