gumbo: update adjusted foreign attributes #2842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add xlink:arcrole - remove xml:base https://html.spec.whatwg.org/multipage/parsing.html#adjust-foreign-attributes
which is upstream at html5lib/html5lib-tests#165
stevecheckoway
approved these changes
Apr 10, 2023
|
It might be worth thinking about how we can stay on top of changes to the spec other than following the whatwg/html repo. |
Yeah, I'm currently following the repo and it's a bit noisy. My hope is that we can pull the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem is this PR intended to solve?
Partial fix for #2841
A test recently added upstream showed that the list of foreign attributes gumbo is adjusting needed to be updated. Specifically:
xlink:arcrolexml:base(see https://html.spec.whatwg.org/multipage/parsing.html#adjust-foreign-attributes)
I've also pinned (for now) to my branch of html5lib-tests, and improved some of the error messages from the tree construction test wrapper.
Have you included adequate test coverage?
This PR is all about the tests! 🎉
Does this change affect the behavior of either the C or the Java implementations?
The HTML5/gumbo functionality changed, but this does not exist in the Java implementation.