miscellaneous TypedData changes #2825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also use consistent style in struct initialization
also deprecate using Node where we expect a Document
flavorjones
added
the
topic/memory
16 tasks
flavorjones
added a commit
that referenced
this pull request
Jul 5, 2023
…ument (#2920) **What problem is this PR intended to solve?** Hackerone user [nmb-se](https://hackerone.com/nmb-se?type=user) (Mikael Borg) reported an issue with typechecking arguments to `XML::Text.new` that could lead to a segfault. This PR fixes the typechecking for `Text.new` as well as similar problems in `CDATA.new` and `Schema.from_document` in both the C and the Java implementations. Related to #2825. **Have you included adequate test coverage?** Yes! **Does this change affect the behavior of either the C or the Java implementations?** Both implementations have been updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem is this PR intended to solve?
See #2808
Note that being more rigorous about types caught a few places where we were being sloppy about accepting Node arguments where Document was expected; and those places have been deprecated with warning messages (see CHANGELOG).
Have you included adequate test coverage?
Tests updated to reflect deprecated argument types.
Does this change affect the behavior of either the C or the Java implementations?
Deprecation warnings added to both C and Java.