Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize rcd_image_version retrieval #2672

Merged
merged 1 commit into from
Oct 18, 2022

Conversation

gjtorikian
Copy link
Contributor

GitHub is deprecating the use of set-output, so this PR removes the warning by updating the same logic to the new sequence.

@flavorjones
Copy link
Member

Hi, I had tried this over the weekend and I believe it won't work because you can't use env in the container.image portion of the job config. I'll click "approve and run" and we'll see?

@flavorjones
Copy link
Member

From the environment files docs

You can make an environment variable available to any subsequent steps in a workflow job by defining or updating the environment variable and writing this to the GITHUB_ENV environment file.

@gjtorikian
Copy link
Contributor Author

Oh, strange. I'm not sure what you tried but I ported these exact changes into my own builds and it works.

@flavorjones
Copy link
Member

Interesting! So if you avoid the ::set-output and use the $GITHUB_ENV file ... you can still use the needs object? 🤯

This PR has some other errors in it, but I'll quickly try another PR and co-author the commit with you!

@flavorjones flavorjones force-pushed the update-ci-version-set branch from c9cab15 to e1d2f17 Compare October 18, 2022 17:53
@flavorjones
Copy link
Member

flavorjones commented Oct 18, 2022

OK, pushed a fixed commit and it seems to be running! 🤞

@flavorjones flavorjones force-pushed the update-ci-version-set branch from e1d2f17 to 11d424c Compare October 18, 2022 17:54
@flavorjones
Copy link
Member

All green! Going to merge. Thank you for showing me how to do this!!

@flavorjones flavorjones merged commit 82140b3 into sparklemotion:main Oct 18, 2022
@gjtorikian gjtorikian deleted the update-ci-version-set branch October 18, 2022 21:08
@gjtorikian
Copy link
Contributor Author

Thank you for showing me how to test and build native gems! 😅 My wish was to pay that forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants