Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: pending test for JRuby schema validation issue #2641

Merged
merged 1 commit into from
Aug 30, 2022
Merged

test: pending test for JRuby schema validation issue #2641

merged 1 commit into from
Aug 30, 2022

Conversation

flavorjones
Copy link
Member

What problem is this PR intended to solve?

#783 describes an issue with JRuby schema validation when passed a blank document.

This introduces a test that's marked "pending" for JRuby to capture the issue.

@flavorjones flavorjones mentioned this pull request Aug 29, 2022
Closed
@flavorjones flavorjones merged commit 1f0e5b4 into main Aug 30, 2022
@flavorjones flavorjones deleted the 783-jruby-schema-validation-pending-test branch August 30, 2022 16:01
@flavorjones flavorjones mentioned this pull request Jun 24, 2024
Merged
flavorjones added a commit that referenced this pull request Jun 24, 2024
@flavorjones
fix(jruby): empty document should fail validation (#3260)
7c8d964 
**What problem is this PR intended to solve?**

Brings the behavior in line with CRuby's impl.

Closes #783.

**Have you included adequate test coverage?**

Yes. Test from #2641.

**Does this change affect the behavior of either the C or the Java
implementations?**

Bring Java in line with CRuby.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs/fix-for-failing-test platform/jruby
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@flavorjones