Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dep: upgrade to libxml 2.10.1 and libiconv 1.17 #2638

Merged
merged 2 commits into from
Aug 28, 2022

Conversation

flavorjones
Copy link
Member

@flavorjones flavorjones commented Aug 27, 2022

What problem is this PR intended to solve?

Closes #2627
Closes #2635

Have you included adequate test coverage?

Existing coverage should be sufficient.

Does this change affect the behavior of either the C or the Java implementations?

Updating the C libraries, so, maybe? This is why we have tests 😂

@flavorjones flavorjones added upstream/libxml2 dependencies Pull requests that update a dependency file labels Aug 27, 2022
@flavorjones flavorjones added this to the v1.14.0 milestone Aug 27, 2022
@flavorjones flavorjones force-pushed the flavorjones-upgrade-libxml2.10.1-libiconv1.17 branch from 6248666 to 6b43645 Compare August 27, 2022 18:37
@flavorjones flavorjones merged commit dbb228a into main Aug 28, 2022
@flavorjones flavorjones deleted the flavorjones-upgrade-libxml2.10.1-libiconv1.17 branch August 28, 2022 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file upstream/libxml2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update vendored libxml2 to 2.10.1 Update vendored libiconv to v1.17
1 participant