Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: better jruby dependency listings in VersionInfo #2545

Merged
merged 2 commits into from
May 12, 2022

Conversation

flavorjones
Copy link
Member

What problem is this PR intended to solve?

After moving to maven-managed dependencies, the output from nokogiri -v looked like:

# Nokogiri (1.14.0.dev)
    ---
    warnings: []
    nokogiri:
      version: 1.14.0.dev
    ruby:
      version: 2.6.8
      platform: java
      gem_platform: universal-java-11
      description: jruby 9.3.2.0 (2.6.8) 2021-12-01 0b8223f905 OpenJDK 64-Bit Server VM
        11.0.15+10-Ubuntu-0ubuntu0.20.04.1 on 11.0.15+10-Ubuntu-0ubuntu0.20.04.1 [linux-x86_64]
      engine: jruby
      jruby: 9.3.2.0
    other_libraries:
      isorelax: isorelax:isorelax:20030108
      Saxon-HE: net.sf.saxon:Saxon-HE:9.6.0-4
      neko-htmlunit: net.sourceforge.htmlunit:neko-htmlunit:2.61.0
      jing: nu.validator:jing:20200702VNU
      nekodtd: org.nokogiri:nekodtd:0.1.11.noko1
      serializer: xalan:serializer:2.7.2
      xalan: xalan:xalan:2.7.2
      xercesImpl: xerces:xercesImpl:2.12.2
      xml-apis: xml-apis:xml-apis:1.4.01

after this PR it looks like:

# Nokogiri (1.14.0.dev)
    ---
    warnings: []
    nokogiri:
      version: 1.14.0.dev
    ruby:
      version: 2.6.8
      platform: java
      gem_platform: universal-java-11
      description: jruby 9.3.2.0 (2.6.8) 2021-12-01 0b8223f905 OpenJDK 64-Bit Server VM
        11.0.15+10-Ubuntu-0ubuntu0.20.04.1 on 11.0.15+10-Ubuntu-0ubuntu0.20.04.1 [linux-x86_64]
      engine: jruby
      jruby: 9.3.2.0
    other_libraries:
      isorelax:isorelax: '20030108'
      net.sf.saxon:Saxon-HE: 9.6.0-4
      net.sourceforge.htmlunit:neko-htmlunit: 2.61.0
      nu.validator:jing: 20200702VNU
      org.nokogiri:nekodtd: 0.1.11.noko1
      xalan:serializer: 2.7.2
      xalan:xalan: 2.7.2
      xerces:xercesImpl: 2.12.2
      xml-apis:xml-apis: 1.4.01

(note the change to other_libraries).

See #2432 for the changeset that introduced the previous format.

Have you included adequate test coverage?

Existing coverage should suffice.

Does this change affect the behavior of either the C or the Java implementations?

Only the JRuby VERSION_INFO has changed.

@flavorjones flavorjones force-pushed the flavorjones-better-jruby-dep-version-info branch from 024bbd8 to e92bb4b Compare May 11, 2022 19:31
@flavorjones flavorjones force-pushed the flavorjones-better-jruby-dep-version-info branch from e92bb4b to 7cec00e Compare May 11, 2022 20:13
@flavorjones flavorjones merged commit 7661464 into main May 12, 2022
@flavorjones flavorjones deleted the flavorjones-better-jruby-dep-version-info branch May 12, 2022 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant