introduce html4 namespace #2278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also make private HTML5::Node#add_child_node_and_reparent_attrs
see https://bugs.ruby-lang.org/issues/8781 which recommends this change.
and make HTML an alias to HTML4. - renamed files, C and Java variables, and Java class names - updated gemspec - updated doc strings - updated usage in lib/ and ext/ to specify HTML4 - added a test asserting on equality of identity of the modules Notably, left the tests alone to ensure this isn't a breaking change.
33 tasks
flavorjones
added a commit
that referenced
this pull request
Nov 28, 2023
**What problem is this PR intended to solve?** Before a minor release, I generally review deprecations and look for things we can remove. * Removed `Nokogiri::HTML5.get` which was deprecated in v1.12.0. [#2278] (@flavorjones) * Removed the CSS-to-XPath utility modules `XPathVisitorAlwaysUseBuiltins` and `XPathVisitorOptimallyUseBuiltins`, which were deprecated in v1.13.0 in favor of `XPathVisitor` constructor args. [#2403] (@flavorjones) * Removed `XML::Reader#attribute_nodes` which was deprecated in v1.13.8 in favor of `#attribute_hash`. [#2598, #2599] (@flavorjones) Also we're now specifying version numbers in remaining deprecation warnings. **Have you included adequate test coverage?** Tests have been removed, otherwise no new coverage needed. **Does this change affect the behavior of either the C or the Java implementations?** As documented above.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem is this PR intended to solve?
As the Nokogumbo merger progresses (see #2204), we now have an
HTML5module and namespace, but the previous libxml2-(and nekohtml-) based functionality is parked under the ambiguousHTMLmodule and namespace.I'd like to disambiguate, and also introduce an opportunity for us to use
HTMLfor more general use in the future (e.g., perhaps detection of HTML doc format and choosing the right DOM parser).This PR moves everything currently under
HTMLtoHTML4, and makesHTMLan alias forHTML4. It updates doc strings and class names.Some changes in behavior that I want to note:
Nokogiri::HTML4::XXXwhere they previously reportedNokogiri::HTML::XXXmNokogiriHTMLis nowmNokogiriHTML4) which might impact anyone writing C code and linking against Nokogiri's dylibHave you included adequate test coverage?
I've left the tests alone (except for the addition of some "HTML/HTML4 equivalence" tests) to demonstrate there's no behavioral breakage.
Does this change affect the behavior of either the C or the Java implementations?
Notably, I've updated the Java files to rename classes and variable, and use the proper module and class names, so that it stays in sync with CRuby despite not having an
HTML5module/namespace.