fix a monkey patch introduced in #1251 #1743
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the patch accidentally removed the parents of the TR element. This caused any document fragment with a dangling (i.e. with no parent) TD or TR element to cause a stack overflow fixes #1501
|
I actually thought about this fix a little more and I don't like it. I think we should get rid of the monkey patch and just accept that different parsing libraries behave differently, something we agreed to do a while back. I'll close this pr and submit a new one with the monkey patch removed and change the xpath in this test to be more permissive |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the patch accidentally removed the parents of the TR element. This caused any
document fragment with a dangling (i.e. with no parent) TD or TR element to
cause a stack overflow
fixes #1501