Only require ports GCC on OpenBSD if not using system libraries (Fixes #1515) #1580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sparklemotion#1515) The OpenBSD system compiler (gcc 4.2.1) cannot compile libxml without patches, but compiles nokogiri itself fine. If using system libraries, there is no need to compile libxml, and therefore the system compiler will work and should be used. If not using system libraries, the code should stay so that compilation of libxml will succeed.
|
Looks perfectly legit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The OpenBSD system compiler (gcc 4.2.1) cannot compile libxml
without patches, but compiles nokogiri itself fine. If using
system libraries, there is no need to compile libxml, and
therefore the system compiler will work and should be used.
If not using system libraries, the code should stay so that
compilation of libxml will succeed.