Cleanup mingw build #1062
Merged
Cleanup mingw build #1062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IN_LIBXML is not necessary when configured with --enable-static, at least for libxml-2.8. Hardcoded libraries to link to are obsolete since knu switched to xml2-config.
Remove cross ruby version checks, since they are obsoleted with the verify_dll method. Add verify_dll to the standard rake-compiler 'cross native gem' tasks, so that it's more compatible with the package_win32_fat_binary command of the rake-compiler-dev-box. Suggest using the rake-compiler-dev-box if no cross rubies are installed, because this is probably the most easiest way to build a proper cross compilation environment.
Closed
|
@larskanis Looks good, so I merged this into my branch in #1071. Could you try it out? |
knu
added a commit
that referenced
this pull request
Apr 2, 2014
|
OK, I think |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attached you can find some cleanup regarding the mingw build process.
The cross build can still be done per
rake gem:windowsor by the build_all script within the rake-compiler-dev-box . It can now be done per standardrake cross native gemcommand, too. It can not yet be done perpackage_win32_fat_binarycommand, but I created an issue on this: tjschuck/rake-compiler-dev-box#8 .