Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Nokogiri::XML::Document#collect_namespaces_[href_keys|prefix_keys] #1001

Closed
wants to merge 2 commits into from

Conversation

wolfgangw
Copy link
Contributor

See #885 for details

@wolfgangw
Copy link
Contributor Author

Is someone willing to help set me up for how to add the required tests for this? I'd like to get it off our desks, either way. Thanks in advance.

- Each of the 2 added methods has their own set of comments.
- Simplify example XML
@wolfgangw
Copy link
Contributor Author

Lee, I used inject to align with collect_namespaces which uses the same method. Maybe change this in all 3 methods with a separate patch?

I've split and simplified the comments to be able to standalone. Also removed the reference to #885

@leejarvis
Copy link
Member

@wolfgangw no problem, I think it's fine for now but since we're not supporting pre 1.9 using stuff like each_with_object where it's sensible makes sense. Thanks for the update, I'll merge this over the weekend.

@flavorjones
Copy link
Member

Closing this. I'm sorry for this response, especially given the amount of time that has passed, but the use case of collect_namespaces is unclear to me, and I'd prefer not to increase the variations of methods unless and until I understand it.

Generally speaking, I'd love for a test case to illustrate how a method is going to be used when possible. I'm happy to entertain this PR again if someone can explain to me the use of this suite of methods around collecting namespaces.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants