-
-
Notifications
You must be signed in to change notification settings - Fork 905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nokogiri 1.6.4 won't compile #1188
Comments
You should at least include the platform name in a report. |
That line looks weird:
|
|
Using
|
Had to use |
OK, I'll look into this. I actually meant |
That would be |
Thanks, now I see the problem. Because of the wrong option CFLAGS passed in are dropped. The above commit should address it. |
@scalp42 Could you please test this? https://gems.idaemons.org/gems/nokogiri-1.6.4.1.test1.gem |
Using
|
@scalp42 Thanks, seems at least it went past the part I fixed. Now we have to look into how libxml2 is failing to build. |
Yep indeed. We gonna pin it to the previous version of Nokogiri in the meantime but thanks a lot for looking into it @knu ! |
@scalp42 Can you locate |
|
My minion @arnaud036 got it for you @knu ! 🎉 |
lol |
Thanks for the quick response! It looks like zlib is missing. Do you have zlib-dev or whatever is called in the OS? What if you installed it? |
Probably nokogiri can check if zlib (libz) is there before kicking the build of libxml2. |
Worked successfully!
|
Package that did it:
Other possible candidate:
|
@scalp42 Great! I suppose libghc-zlib-dev might be too much; zlib1g-dev should suffice on your platform. |
Thanks a lot for jumping on this. Do you have an idea on the timeline to push to rubygems please? |
@scalp42 Hopefully in a couple of days. Thanks much for your feedback! |
Added a check for zlib. @scalp42 I'd really appreciate if you could kindly test it:
|
I want to kiss you all right on the mouth. Many hours spent banging head against wall... installing zlib1g-dev prior to installing the gem resolved it. |
@knu sorry for the delay here, gonna try right now. |
Without
I don't see any message related to zlib missing (e7c4756) |
Source builds on 64bit win8.1 mri 2.1.5-p270 32bit also borked due to bad |
@scalp42 Thanks for testing! I didn't expect it would find gzdopen() in -lz (which is checked with |
@knu let me try to find which package providing it. |
Ubuntu 12.04 reports: I'll look on a box to make sure. |
Unfortunately, I get no matches. The only
Which might be why nothing is being triggered ?
|
There appears to be two different issues being discussed here -- one is the Would someone mind submitting a pull request to On Thu, Nov 6, 2014 at 6:48 PM, Anthony Scalisi [email protected]
|
The bug for CFLAGS is fixed in The other one for zlib is related to the actual output. |
Riiight, I understand what you're saying, but I'd like to make sure that we On Thu, Nov 6, 2014 at 7:46 PM, Anthony Scalisi [email protected]
|
Also, I'd like to try to capture errors in the build process during our pre-release tests. We've had build problems with a couple of recent releases and I'd like to get better about spotting these problems before release. @knu, any ideas on what we could have done better in this instance? Do we need better platform coverage? |
@knu, your commit breaks the windows build process. I'll poke you on Slack. |
I've released v1.6.4.1 addressing the :werror compilation issue. On Thu, Nov 6, 2014 at 8:21 PM, Mike Dalessio [email protected]
|
Installing with |
@ain can you please attach the contents of your |
Update: upgrading Ruby to |
Currently the 1.9.2 build is failing on Travis. Refs sparklemotion/nokogiri#1188
I'm getting the following error while building 1.6.4.1 on Mac OS X 10.9.5 Xcode 6.1 with Ruby 2.1.3, 2.1.4, 2.1.5.
I have tried building against system libs and I get different errors. |
Here is the libxml2 compile.log file:
|
Hi @nvick, your problem is different from the one that generated this ticket. Can you please open a new issue for this? I apologize for the hassle and appreciate your help organizing the Nokogiri backlog. |
@jonbca thanks, your solution worked (centos 7.1) :) |
@arnaud036 Thanks bro |
The original two problems described in this ticket have been fixed, one by updating compiler flags, and the other by documenting the zlib requirement in the nokogiri.org installation tutorial. Locking ticket, please open a new one if you're experiencing problems. |
Hi there,
We had to rollback to nokogiri 1.6.3.1 with libxml2 (2.9.0 instead of 2.9.2).
Log incoming.
Ubuntu 12.04 LTS
The text was updated successfully, but these errors were encountered: