fixing a segfault when an empty string is sent to Node#inner_html=. c…

…loses #88

CHANGELOG.rdoc

@@ -8,6 +8,7 @@
 
   * Override libxml-ruby's global error handler
   * ParseOption#strict fixed
+  * Fixed a segfault when sending an empty string to Node#inner_html= GH #88
 
 === 1.3.2 / 2009-06-22
 

lib/nokogiri/html/sax/parser.rb

@@ -30,7 +30,8 @@ class Parser < Nokogiri::XML::SAX::Parser
         # Parse html stored in +data+ using +encoding+
         def parse_memory data, encoding = 'UTF-8'
           raise ArgumentError unless data
-          native_parse_memory(data, encoding)
+          return unless data.length > 0
+          native_parse_memory data, encoding
         end
 
         ###

test/helper.rb

@@ -2,6 +2,7 @@
 $VERBOSE = true
 require 'rubygems'
 require 'test/unit'
+require 'tempfile'
 
 %w(../lib ../ext).each do |path|
   $LOAD_PATH.unshift(File.expand_path(File.join(File.dirname(__FILE__), path)))

test/html/sax/test_parser.rb

@@ -9,6 +9,18 @@ def setup
           @parser = HTML::SAX::Parser.new(Doc.new)
         end
 
+        def test_parse_empty_document
+          # This caused a segfault in libxml 2.6.x
+          assert_nothing_raised { @parser.parse '' }
+        end
+
+        def test_parse_empty_file
+          # Make sure empty files don't break stuff
+          empty_file_name =  File.join(Dir.tmpdir, 'bogus.xml')
+          FileUtils.touch empty_file_name
+          assert_nothing_raised { @parser.parse_file empty_file_name }
+        end
+
         def test_parse_file
           @parser.parse_file(HTML_FILE)
           assert_equal 1110, @parser.document.end_elements.length