style(rubocop): frozen string literals everywhere

sparklemotion · Oct 26, 2021 · 49073d3 · 49073d3
1 parent 6dcb357
commit 49073d3
Show file tree

Hide file tree

Showing 79 changed files with 141 additions and 7 deletions.
diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
@@ -379,13 +379,6 @@ Style/EachWithObject:
   Exclude:
     - 'lib/nokogiri/xml/document.rb'
 
-# Offense count: 78
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: always, always_true, never
-Style/FrozenStringLiteralComment:
-  Enabled: false
-
 # Offense count: 2
 Style/MissingRespondToMissing:
   Exclude:

diff --git a/Gemfile b/Gemfile
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 source "https://rubygems.org"
 
 gemspec
diff --git a/Vagrantfile b/Vagrantfile
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # -*- mode: ruby -*-
 # vi: set ft=ruby :
 

diff --git a/rakelib/clean.rake b/rakelib/clean.rake
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "rake/clean"
 CLEAN.add(
   "coverage",

diff --git a/rakelib/css-generate.rake b/rakelib/css-generate.rake
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 namespace "css" do
   PARSER_DEPS = { "lib/nokogiri/css/parser.rb" => "lib/nokogiri/css/parser.y" }
   TOKENIZER_DEPS = { "lib/nokogiri/css/tokenizer.rb" => "lib/nokogiri/css/tokenizer.rex" }

diff --git a/rakelib/debug.rake b/rakelib/debug.rake
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 desc "Set environment variables to build and/or test with debug options"
 task :debug do
   ENV["NOKOGIRI_DEBUG"] = "true"

diff --git a/rakelib/docker.rake b/rakelib/docker.rake
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 #
 # docker docker docker
 #

diff --git a/rakelib/extensions.rake b/rakelib/extensions.rake
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "rbconfig"
 require "shellwords"
 

diff --git a/rakelib/gumbo.rake b/rakelib/gumbo.rake
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 namespace "gumbo" do
   gtest_pkg = "gumbo-parser/googletest"
   gtest_lib = File.join(gtest_pkg, "make/gtest_main.a")

diff --git a/rakelib/markdown.rake b/rakelib/markdown.rake
@@ -1,2 +1,4 @@
+# frozen_string_literal: true
+
 require "hoe/markdown"
 Hoe::Markdown::Standalone.new("nokogiri").define_markdown_tasks("CHANGELOG.md", "CONTRIBUTING.md")
diff --git a/rakelib/package.rake b/rakelib/package.rake
@@ -1,2 +1,4 @@
+# frozen_string_literal: true
+
 require "rubygems/package_task"
 Gem::PackageTask.new(NOKOGIRI_SPEC).define
diff --git a/rakelib/rubocop.rake b/rakelib/rubocop.rake
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "rubocop/rake_task"
 
 module RubocopHelper

diff --git a/rakelib/test.rake b/rakelib/test.rake
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "rake/testtask"
 
 #

diff --git a/scripts/files-modified-by-open-prs b/scripts/files-modified-by-open-prs
@@ -1,4 +1,6 @@
 #! /usr/bin/env ruby
+# frozen_string_literal: true
+
 #
 #  script to see what PRs, if any, are operating on a file that I care about.
 #  yes, this is a smell. we shouldn't have long-lived PRs, but alas here we are.

diff --git a/scripts/generate-html5-entities b/scripts/generate-html5-entities
@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
 
 # Copyright 2018 Stephen Checkoway
 #

diff --git a/scripts/test-exported-symbols b/scripts/test-exported-symbols
@@ -1,4 +1,6 @@
 #! /usr/bin/env ruby
+# frozen_string_literal: true
+
 #
 #  examine the nokogiri dll for external symbols that shouldn't be there
 #

diff --git a/test/css/test_css_integration.rb b/test/css/test_css_integration.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "helper"
 
 module Nokogiri

diff --git a/test/css/test_tokenizer.rb b/test/css/test_tokenizer.rb
@@ -1,4 +1,5 @@
 # -*- coding: utf-8 -*-
+# frozen_string_literal: true
 
 require "helper"
 

diff --git a/test/decorators/test_slop.rb b/test/decorators/test_slop.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "helper"
 
 module Nokogiri

diff --git a/test/html4/sax/test_parser.rb b/test/html4/sax/test_parser.rb
@@ -1,4 +1,5 @@
 # -*- coding: utf-8 -*-
+# frozen_string_literal: true
 
 require "helper"
 

diff --git a/test/html4/sax/test_parser_context.rb b/test/html4/sax/test_parser_context.rb
@@ -1,4 +1,5 @@
 # -*- coding: utf-8 -*-
+# frozen_string_literal: true
 
 require "helper"
 

diff --git a/test/html4/sax/test_parser_text.rb b/test/html4/sax/test_parser_text.rb
@@ -1,4 +1,5 @@
 # -*- coding: utf-8 -*-
+# frozen_string_literal: true
 
 require "helper"
 

diff --git a/test/html4/test_attributes.rb b/test/html4/test_attributes.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "helper"
 
 module Nokogiri

diff --git a/test/html4/test_attributes_properly_escaped.rb b/test/html4/test_attributes_properly_escaped.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "helper"
 
 module Nokogiri

diff --git a/test/html4/test_builder.rb b/test/html4/test_builder.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "helper"
 
 module Nokogiri

diff --git a/test/html4/test_comments.rb b/test/html4/test_comments.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "helper"
 
 module Nokogiri

diff --git a/test/html4/test_element_description.rb b/test/html4/test_element_description.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "helper"
 
 module Nokogiri

diff --git a/test/html4/test_named_characters.rb b/test/html4/test_named_characters.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "helper"
 
 module Nokogiri

diff --git a/test/html4/test_node.rb b/test/html4/test_node.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "helper"
 
 require "nkf"

diff --git a/test/html4/test_node_encoding.rb b/test/html4/test_node_encoding.rb
@@ -1,4 +1,5 @@
 # -*- coding: utf-8 -*-
+# frozen_string_literal: true
 
 require "helper"
 

diff --git a/test/html5/test_monkey_patch.rb b/test/html5/test_monkey_patch.rb
@@ -1,4 +1,5 @@
 # encoding: utf-8
+# frozen_string_literal: true
 
 require "helper"
 

diff --git a/test/namespaces/test_additional_namespaces_in_builder_doc.rb b/test/namespaces/test_additional_namespaces_in_builder_doc.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "helper"
 
 module Nokogiri

diff --git a/test/namespaces/test_namespaces_aliased_default.rb b/test/namespaces/test_namespaces_aliased_default.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "helper"
 
 module Nokogiri

diff --git a/test/namespaces/test_namespaces_in_builder_doc.rb b/test/namespaces/test_namespaces_in_builder_doc.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "helper"
 
 module Nokogiri

diff --git a/test/namespaces/test_namespaces_in_cloned_doc.rb b/test/namespaces/test_namespaces_in_cloned_doc.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "helper"
 
 module Nokogiri

diff --git a/test/namespaces/test_namespaces_in_created_doc.rb b/test/namespaces/test_namespaces_in_created_doc.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "helper"
 
 module Nokogiri

diff --git a/test/namespaces/test_namespaces_in_parsed_doc.rb b/test/namespaces/test_namespaces_in_parsed_doc.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "helper"
 
 module Nokogiri

diff --git a/test/namespaces/test_namespaces_preservation.rb b/test/namespaces/test_namespaces_preservation.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "helper"
 
 module Nokogiri

diff --git a/test/test_convert_xpath.rb b/test/test_convert_xpath.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "helper"
 
 class TestConvertXPath < Nokogiri::TestCase

diff --git a/test/test_css_cache.rb b/test/test_css_cache.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "helper"
 
 class TestCssCacheAccess < Nokogiri::TestCase

diff --git a/test/test_encoding_handler.rb b/test/test_encoding_handler.rb
@@ -1,4 +1,5 @@
 # -*- coding: utf-8 -*-
+# frozen_string_literal: true
 
 require "helper"
 

diff --git a/test/test_gem_platform.rb b/test/test_gem_platform.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "helper"
 
 class TestGemPlatform < Nokogiri::TestCase

diff --git a/test/test_iso.rb b/test/test_iso.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "helper"
 
 class TestISO < Nokogiri::TestCase

diff --git a/test/test_memory_leak.rb b/test/test_memory_leak.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "helper"
 
 class TestMemoryLeak < Nokogiri::TestCase

diff --git a/test/test_nokogumbo_contract.rb b/test/test_nokogumbo_contract.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "helper"
 
 describe "Nokogumbo contract expectations" do

diff --git a/test/test_soap4r_sax.rb b/test/test_soap4r_sax.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "helper"
 
 module XSD

diff --git a/test/xml/node/test_attribute_methods.rb b/test/xml/node/test_attribute_methods.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "helper"
 
 class Nokogiri::XML::Node

diff --git a/test/xml/node/test_save_options.rb b/test/xml/node/test_save_options.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "helper"
 
 module Nokogiri

diff --git a/test/xml/node/test_subclass.rb b/test/xml/node/test_subclass.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "helper"
 
 module Nokogiri

diff --git a/test/xml/sax/test_document_error.rb b/test/xml/sax/test_document_error.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "helper"
 
 module Nokogiri

diff --git a/test/xml/sax/test_parser_context.rb b/test/xml/sax/test_parser_context.rb
@@ -1,4 +1,5 @@
 # -*- coding: utf-8 -*-
+# frozen_string_literal: true
 
 require "helper"
 

diff --git a/test/xml/sax/test_parser_text.rb b/test/xml/sax/test_parser_text.rb
@@ -1,4 +1,5 @@
 # -*- coding: utf-8 -*-
+# frozen_string_literal: true
 
 require "helper"
 

diff --git a/test/xml/test_attr.rb b/test/xml/test_attr.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "helper"
 
 module Nokogiri

diff --git a/test/xml/test_attribute_decl.rb b/test/xml/test_attribute_decl.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "helper"
 
 module Nokogiri

diff --git a/test/xml/test_builder.rb b/test/xml/test_builder.rb
@@ -1,4 +1,5 @@
 # -*- coding: utf-8 -*-
+# frozen_string_literal: true
 
 require "helper"
 

diff --git a/test/xml/test_c14n.rb b/test/xml/test_c14n.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "helper"
 
 module Nokogiri

diff --git a/test/xml/test_cdata.rb b/test/xml/test_cdata.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "helper"
 
 module Nokogiri

diff --git a/test/xml/test_comment.rb b/test/xml/test_comment.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "helper"
 
 module Nokogiri

diff --git a/test/xml/test_document_encoding.rb b/test/xml/test_document_encoding.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "helper"
 
 module Nokogiri

diff --git a/test/xml/test_dtd.rb b/test/xml/test_dtd.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "helper"
 
 module Nokogiri

diff --git a/test/xml/test_dtd_encoding.rb b/test/xml/test_dtd_encoding.rb
@@ -1,4 +1,5 @@
 # -*- coding: utf-8 -*-
+# frozen_string_literal: true
 
 require "helper"
 

diff --git a/test/xml/test_element_content.rb b/test/xml/test_element_content.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "helper"
 
 module Nokogiri

diff --git a/test/xml/test_element_decl.rb b/test/xml/test_element_decl.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "helper"
 
 module Nokogiri

diff --git a/test/xml/test_entity_decl.rb b/test/xml/test_entity_decl.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "helper"
 
 module Nokogiri

diff --git a/test/xml/test_entity_reference.rb b/test/xml/test_entity_reference.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "helper"
 
 module Nokogiri