Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use default NSURLRequest timeoutInterval (currently 60s) #2673

Merged
merged 1 commit into from
Dec 9, 2024
Merged

Use default NSURLRequest timeoutInterval (currently 60s) #2673

merged 1 commit into from
Dec 9, 2024

Conversation

zorgiepoo
Copy link
Member

@zorgiepoo zorgiepoo commented Dec 9, 2024 •
edited
Loading

Misc Checklist

  • My change requires a documentation update on Sparkle's website repository
  • My change requires changes to generate_appcast, generate_keys, or sign_update

Testing

I tested and verified my change by using one or multiple of these methods:

  • Sparkle Test App
  • Unit Tests
  • My own app
  • Other (please specify)

Tested downloading data (release notes, feed, update) still works.

macOS version tested: 15.1 (24B83)

@zorgiepoo zorgiepoo added this to the 2.7 milestone Dec 9, 2024
@zorgiepoo zorgiepoo mentioned this pull request Dec 9, 2024
Closed
@zorgiepoo zorgiepoo merged commit 9902f2f into 2.x Dec 9, 2024
2 checks passed
@zorgiepoo zorgiepoo deleted the use-default-request-timeout branch December 9, 2024 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.7
Development

Successfully merging this pull request may close these issues.
1 participant
@zorgiepoo