Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase max mach service name length to 127 characters #1813

Merged
merged 2 commits into from
Apr 4, 2021

Conversation

zorgiepoo
Copy link
Member

@zorgiepoo zorgiepoo commented Apr 4, 2021

Increase max mach service name length to 127 characters.

The installer and progress tool broadcast mach service names that are prefixed with the host bundle's identifier. Previously this would be truncated from the right to 63 characters but we can increase the limit to 127 characters as 10.8 is no longer supported.

Checklist:

  • My change is being tested and reviewed against the Sparkle 2.x branch. New changes must be developed on the 2.x development branch first.
  • My change is being backported to master branch (Sparkle 1.x). Please create a separate pull request for 1.x, should it be backported. Note 1.x is feature frozen and is only taking bug fixes, localization updates, and critical OS adoption enhancements.
  • I have reviewed and commented my code, particularly in hard-to-understand areas.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • My change is or requires a documentation or localization update

Testing

I tested and verified my change by using one or multiple of these methods:

  • Sparkle Test App
  • Unit Tests
  • My own app
  • Other (please specify)

Tested max service name with 127 characters works but 128 characters doesn't work.

macOS version tested:
latest 10.9 in VM
11.2.3 (20D91)

@zorgiepoo zorgiepoo merged commit faf047c into 2.x Apr 4, 2021
@zorgiepoo zorgiepoo deleted the service-length branch April 4, 2021 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants