Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct ZED-F9P, NEO-D9S_and_NEO-D9C Examples (fixType==4) #46

Merged

Conversation

niabassey
Copy link
Contributor

@niabassey niabassey commented Jan 2, 2024

GNSS + Dead Reckoning is Fix Type 4, not Fix Type 3.
See page 104 of https://content.u-blox.com/sites/default/files/documents/u-blox-F9-HPG-1.32_InterfaceDescription_UBX-22008968.pdf

Looks like "else if (fixType == 3)" was accidentally duplicated

This bug appears in the NEO-D9S_and_NEO-D9C and ZED-F9P Examples

@niabassey niabassey changed the title Correct f9p examples fixType Correct ZED-F9P Examples fixType Jan 2, 2024
GNSS + Dead Reckoning is FixType 4, not FixType 3.
GNSS + Dead Reckoning is FixType 4, not FixType 3.
GNSS + Dead Reckoning is FixType 4, not FixType 3.
GNSS + Dead Reckoning is FixType 4, not FixType 3.
GNSS + Dead Reckoning is FixType 4, not FixType 3.
GNSS + Dead Reckoning is FixType 4, not FixType 3.
@niabassey niabassey changed the title Correct ZED-F9P Examples fixType Correct ZED-F9P, NEO-D9S_and_NEO-D9C Examples (fixType==4) Jan 2, 2024
@PaulZC
Copy link
Collaborator

PaulZC commented Jan 3, 2024

Hello Nia (@niabassey ),

Thank you for finding this! These errors has been around for a long time - they came from v2 of the library.

I will merge this into the release_candidate branch and release it later today.

Very best wishes,
Paul

@PaulZC PaulZC changed the base branch from main to release_candidate January 3, 2024 06:30
@PaulZC PaulZC merged commit 4c1aab7 into sparkfun:release_candidate Jan 3, 2024
10 checks passed
@niabassey niabassey deleted the correct-f9p-examples-fix-type branch January 3, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants