Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More changes - primarily for the Reference Station on Ethernet #471

Merged
merged 36 commits into from
May 24, 2023

Conversation

PaulZC
Copy link
Contributor

@PaulZC PaulZC commented May 22, 2023

  • ntripServerUseWiFiNotEthernet and ntripClientUseWiFiNotEthernet eat too much RAM on the Ref Stn
    • These have been commented out and marked "For future expansion"
  • RTK restarts if the uartReceiveBufferSize or gnssHandlerBufferSize are modified via the system menu
    • Much badness happened if the code attempted to use the new size - when the alloc's etc. were all set up using the old size
  • handleGNSSDataTask, wifiSendTcpData and tcpUpdate have been restructured
    • The TCP client / server connections are now handled by tcpUpdate
    • wifiSendTcpData now only sends data - and only does so if the server or client are actually online and at least one client is connected
  • Adds menu and config page warnings that TCP Server and Client can not be enabled at the same time
  • index_html and main_js are now zipped into form.h automatically - by compile-rtk-firmware.yml
  • Fixes the mythical SFE file bug - and adds the preceding slash correctly when reusing the previous log file
  • Fixes a bug where the Ethernet web server was not being ended correctly if the RTK was shut down from ConfigViaEthernet
  • Displays the correct SD card size and free space in the File Transfer configuration page tab - allows time for the SD size check task to complete in the background
  • Fixes a bug where the base and rover RTCM messages were not being displayed in ConfigViaEthernet
  • Adds Enable ARP Logging
    • The base location is parsed from incoming RTCM 1005 and 1006 messages and can be logged as a custom NMEA message
    • Accessible from the System menu
  • Avoids using String as a function return type
    • Changed so that the String is returned via a pointer instead
    • Prevents badness if the (non-static) String goes out of scope

PaulZC added 30 commits May 9, 2023 18:48
It's not clear if/when the String goes out of scope - if it's not static internally. Passing a pointer is better.
Also ensure lastLogName has a preceding slash
@PaulZC PaulZC requested a review from nseidle May 22, 2023 14:10
Copy link
Member

@nseidle nseidle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is huge. Thanks! Looks good.

@nseidle nseidle merged commit c6d3f5b into release_candidate May 24, 2023
@PaulZC PaulZC deleted the Add_Ref_Stn_Ethernet branch June 23, 2023 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants