Use getSatellitesInViewCount()

Fix #505. In Base mode, getSatellitesInViewCount is correctly calculated where as getSatellitesUsedCount is always zero.
sparkfun · Dec 18, 2024 · 1a0baed · 1a0baed
1 parent efd7b2a
commit 1a0baed
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/Firmware/RTK_Everywhere/GNSS_LG290P.ino b/Firmware/RTK_Everywhere/GNSS_LG290P.ino
@@ -1111,9 +1111,10 @@ uint8_t GNSS_LG290P::getRtcmMessageNumberByName(const char *msgName)
 uint8_t GNSS_LG290P::getSatellitesInView()
 {
     if (online.gnss)
-        // return (_lg290p->getSatellitesInView());
-        // Use getSatellitesUsed until SIV works correctly
-        return (_lg290p->getSatellitesUsedCount());
+        return (_lg290p->getSatellitesInViewCount() - 4);
+        // As of v1.0.1 of the LG290P library, getSatellitesInViewCount is reporting staillites that
+        // have 0 in view ("00"). NAVIC and QZSS satellites are the most common problem. Artificially
+        // reducing until a fix is in place.
     return 0;
 }
 

diff --git a/Firmware/RTK_Everywhere/menuSystem.ino b/Firmware/RTK_Everywhere/menuSystem.ino
@@ -1146,10 +1146,10 @@ void menuPeriodicPrint()
         systemPrint("7) WiFi state: ");
         systemPrintf("%s\r\n", PERIODIC_SETTING(PD_WIFI_STATE) ? "Enabled" : "Disabled");
 
-        systemPrint("8) ZED RX data: ");
+        systemPrint("8) GNSS RX data: ");
         systemPrintf("%s\r\n", PERIODIC_SETTING(PD_GNSS_DATA_RX) ? "Enabled" : "Disabled");
 
-        systemPrint("9) ZED TX data: ");
+        systemPrint("9) GNSS TX data: ");
         systemPrintf("%s\r\n", PERIODIC_SETTING(PD_GNSS_DATA_TX) ? "Enabled" : "Disabled");
 
         systemPrintln("-----  Software  -----");