emergency reset disabled by default #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initialize settingIgnoreRX to false. In emergency reset, use default value for contrast instead of literal, and set brightnesses to defaults.
exchange DEFAULT_BRIGHTNESS for DEFAULT_RED, DEFAULT_GREEN and DEFAULT_BLUE
|
This is excellent! Thank you for fixing my bad logic and adding a few new things. |
nseidle
added a commit
that referenced
this pull request
Mar 18, 2019
|
Thanks for doing the lion's share of the work!
I've a lot more enhancements in the pipeline. You can follow them in the
wiki on my fork if you're interested. Comments encouraged.
…On Mon, Mar 18, 2019, 12:34 Nathan Seidle ***@***.***> wrote:
This is excellent! Thank you for fixing my bad logic and adding a few new
things.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#21 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AJ_Kp1Adgqo72ZftShz0yo_hrSPXiTFDks5vX8ARgaJpZM4b4LbY>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improper initialization of settingIgnoreRX caused RX to be ignored by default. Probably due to it being changed from a byte to a boolean between revisions.
Also made small enhancements to brightness settings.