feat: rebuild Location page #435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
yosevu
force-pushed
the
feat--rebuild-location-page
branch
7 times, most recently
from
7da70a7 to
7eb9801
Compare
Resolves #414 - chore: ignore declaration-block-no-redundant-longhand-properties Stylelint rule due to low-priority issue. - refactor: restructure components - test: add basic LocationPage tests - fix: correct static asset paths - refactor: rename LocationOverview and review-overview to LocationDetails - fix: pass location id only state to LocationPage and load locations data on LocationPage - refactor: use map for initial locations data structure for easy lookups on LocationPage - refactor: alias Window Location `WindowLocation` to prevent conclicts with Sparkeats `Location` - refactor: update imageURL logic to differentiate Review and Location image placeholders. - refactor: use useLocations hook
yosevu
force-pushed
the
feat--rebuild-location-page
branch
from
7eb9801 to
8f46062
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses issue #414.
What changed?
WindowLocationto prevent conclicts with SparkeatsLocationImpacts
How did you test the changes?
Screenshots