feat: Use NVM for Node instead of brew #11
Conversation
robtarr
commented
Aug 5, 2018
robtarr
commented
- Install NVM
- Uninstall brew installed Node
- Install Node with NVM
- Install NVM - Uninstall brew installed Node - Install Node with NVM
There was a problem hiding this comment.
One question, doesn't need addressed here.
One formatting thing with the spaces.
I'm good to merge after that.
Just realized I didn't run it 🤦♂️
Here's where I'm at:
- looks like there is some thing weird happening with npm right after install of nvm
- for some reason the install is failing. it's not clear what that is though.
oddly, brew list still shows all the node@ versions, including node@4 even after the cleanup.
mac
Outdated
| @@ -59,6 +59,13 @@ brew_uninstall() { | |||
| fi | |||
| } | |||
|
|
|||
| brew_cleanup() { | |||
mac
Outdated
| brew_cleanup() { | ||
| if brew_is_installed "$1"; then | ||
| fancy_echo "Cleaning up %s ..." "$1" | ||
| brew cleanup "$@" |
There was a problem hiding this comment.
Should we replace brew_uninstall with this? Kinda seems like cleanup is better.
There was a problem hiding this comment.
I notice 2 different references for the parameter $1 and $@... maybe that's why the cleanup isn't happening?
mac
Outdated
| # Install NVM | ||
| if ! command -v nvm >/dev/null; then | ||
| fancy_echo "Installing NVM ..." | ||
| curl -o- https://raw.githubusercontent.com/creationix/nvm/v0.33.11/install.sh | $SHELL |
There was a problem hiding this comment.
Not a biggie, but there's a weird extra few spaces before $SHELL. ¯_(ツ)_/¯
Kinda sucks they don't have a stable tag 😞
mac
Outdated
| export NVM_DIR="$HOME/.nvm" | ||
| [ -s "$NVM_DIR/nvm.sh" ] && \. "$NVM_DIR/nvm.sh" | ||
| else | ||
| fancy_echo "NVM already installed. Skipping ..."bash "" |
|
@robtarr I get this when I run the script: |
