Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: return 404 status code when route isn't found #380

Merged
merged 1 commit into from
Jan 30, 2023
Merged

fix: return 404 status code when route isn't found #380

merged 1 commit into from
Jan 30, 2023

Conversation

AntoineRR
Copy link
Collaborator

Description

This PR fixes #376

@netlify
Copy link

netlify bot commented Jan 29, 2023 •
edited
Loading

✅ Deploy Preview for robyn canceled.

Name Link
🔨 Latest commit a86a0bd
🔍 Latest deploy log https://app.netlify.com/sites/robyn/deploys/63d7fb6e0f45bd00087c416f

sansyrox
sansyrox approved these changes Jan 30, 2023
View reviewed changes
Copy link
Member

@sansyrox sansyrox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very neat! ✨

sansyrox
sansyrox approved these changes Jan 30, 2023
View reviewed changes
Copy link
Member

@sansyrox sansyrox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@sansyrox sansyrox merged commit 940ee51 into sparckles:main Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sansyrox sansyrox sansyrox approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Return 404 status code when route isn't set
2 participants
@AntoineRR @sansyrox