fix: return 404 status code when route isn't found (#380)

sparckles · Jan 30, 2023 · 940ee51 · 940ee51
1 parent 3aed256
commit 940ee51
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/integration_tests/test_status_code.py b/integration_tests/test_status_code.py
@@ -13,6 +13,12 @@ def test_404_post_request_status_code(session):
     assert r.status_code == 404
 
 
+def test_404_not_found(session):
+    r = requests.get(f"{BASE_URL}/actually_not_found_route")
+    assert r.status_code == 404
+    assert r.text == "Not found"
+
+
 def test_307_get_request(session):
     r = requests.get(f"{BASE_URL}/redirect")
     assert r.text == "This is the redirected route"

diff --git a/src/server.rs b/src/server.rs
@@ -385,7 +385,8 @@ async fn index(
             }
         }
     } else {
-        response_builder.finish()
+        response_builder.status(StatusCode::NOT_FOUND);
+        response_builder.body("Not found")
     };
 
     apply_middleware(