Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add an auto benchmark script #329

Merged
merged 2 commits into from
Dec 16, 2022
Merged

Conversation

AntoineRR
Copy link
Collaborator

Description

This PR fixes #320

  • Add a benchmark shell script that runs oha
  • Change the way Robyn handle signals to shut down (Now supports SIGTERM)

Feel free to ask if you think I missed some features for the benchmark!

@netlify
Copy link

netlify bot commented Dec 3, 2022

Deploy Preview for robyn canceled.

Name Link
🔨 Latest commit d626c91
🔍 Latest deploy log https://app.netlify.com/sites/robyn/deploys/638d14f889462400090f89e4

benchmark.sh Show resolved Hide resolved
Copy link
Member

@sansyrox sansyrox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! One test timed out for some reason but looks great otherwise 👍

@sansyrox sansyrox merged commit 787f34b into sparckles:main Dec 16, 2022
@sansyrox
Copy link
Member

Thank you! :D

sansyrox pushed a commit that referenced this pull request Dec 18, 2022
* feat: add an auto benchmark script

* feat(benchmark): add a help flag
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Add an automated benchmark script
2 participants