fix: kill all server-related processes on test session end #277
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes #249
Changes
process.terminate()
withos.killpg()
. The former does not kill child processes spawned, while the latter does.os.killpg()
(POSIX) orprocess.kill()
(non-POSIX) as per host OSDocumentation
How I've tested my work
Passed 25/25 tests on running
pytest
inside integration_tests/ (Debian 10)Pending:
pytest
inside integration_tests/python3
invoked in shell instead ofpython
- for Windows versions of Python (i.e. not WSL), python3 is not typically a standard alias